Roll back to original usage of sycl::get_kernel_bundle #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR rolls back the usage of sycl::get_kernel_bundle to its original device-agnostic form, removing a workaround that was needed for oneAPI versions prior to 2025.2. The change eliminates device-specific kernel bundle creation and the associated comments explaining the workaround.
- Reverts
sycl::get_kernel_bundlecall to use only kernel ID instead of both device and kernel ID - Removes workaround comments that referenced a specific GitHub issue
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fengyuan14
approved these changes
Aug 19, 2025
chunhuanMeng
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #1121.
The original usage of
sycl::get_kernel_bundleshould not be device-specific. Since the fixing has landed on oneAPI 2025.2, kernel bundle is now created using only the kernel ID (kid) instead of both device and kernel ID, removing the workaround for device-specific kernel builds and associated comments.