Fix bugs in LogicStructure
instrumentation calls to packed
and changed
issues across Simulator.reset
#458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This PR addresses two categories of issues:
LogicStructure
s would callpacked
sometimes, which could result in non-functional generation impact and unexpectednull
s in things likepreviousValue
. Non-synthesizable APIs onLogicStructure
rely onpacked
#457changed
mechanism inLogic
did not work properly acrossSimulator.reset
calls, so this PR also fixes these issues. This was discovered during fixes to the first bullet.Related Issue(s)
Fix #457
Testing
Added new tests
Backwards-compatibility
No
Documentation
No