-
Notifications
You must be signed in to change notification settings - Fork 798
[SYCL] Add UUID and sub-, sub-sub- device info in sycl-ls --verbose
#13999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if (Device.has(aspect::ext_intel_device_info_uuid)) { | ||
auto UUID = Device.get_info<sycl::ext::intel::info::device::uuid>(); | ||
std::cout << Prepend << "UUID : "; | ||
for (int i = 0; i < 16; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you be using ZE_MAX_DEVICE_UUID_SIZE instead of assuming size is 16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That can be done. But, Isn't the UUID size fixed to 16: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_intel_device_info.md#device-uuid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is documented as 16 then ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just use a range-based for loop on UUID
@@ -0,0 +1,15 @@ | |||
/* Test to check that sycl-ls is outputting UUID and number of sub and sub-sub | |||
* devices. */ | |||
// REQUIRES: gpu, level_zero |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this work on Gen12 ? Or is it PVC only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work on Gen12 as well. The test passes on Gen12 precommit: https://github.com/intel/llvm/actions/runs/9343215312/job/25714501971
Pre commit failure in Linux Gen12 is in |
@intel/llvm-gatekeepers The PR is ready! |
Example
sycl-ls --verbose
output: