Skip to content

Conversation

liu-shaojun
Copy link
Contributor

@liu-shaojun liu-shaojun commented Oct 11, 2024

Description

1. Why the change?

This submission upgrades oneccl to 0.0.4 and pins transformers version to 4.44.2 to fix zai-org/ChatGLM3#1324

2. User API changes

3. Summary of the change

4. How to test?

5. New dependencies

  • New Python dependencies
    - Dependency1
    - Dependency2
    - ...
  • New Java/Scala dependencies and their license
    - Dependency1 and license1
    - Dependency2 and license2
    - ...

Copy link
Contributor

@glorysdj glorysdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liu-shaojun liu-shaojun merged commit 1daab45 into main Oct 11, 2024
@liu-shaojun liu-shaojun deleted the release_oneccl_0.0.4 branch October 11, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: ChatGLMTokenizer._pad() got an unexpected keyword argument 'padding_side'

2 participants