Set mistral fuse rope to false except fp6 & fp16 #11765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiyuangong
added a commit
that referenced
this pull request
Aug 13, 2024
* Fix mistral forward_qkv without self.rotary_emb.base in q4_0. * Replace apply_rotary_pos_emb_no_cache_xpu with rotary_half_inplaced. * Revert #11765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr set the fuse rope of
mistralmodel toFalsePR-11747 fixed the
mistral-7B-instruct-v0.2FP16results difference between ipex-llm/ipex/NV in Longbench. However, this caused some other precisions likesym_int4output garbled characters. This pr disabled the fuse rope optimization as a workaround to solve this problem (temporarily) .Note
Since
fuse qkvis also disabled in this case, it will cause a decrease to the model performance