Unrecognised flag exception for HS_FLAG_COMBINATION in ParsedExpression::ParsedExpression

[foxever]

HS_FLAG_ALL is not include all valid hyperscan flags, which may cause flags check failed, eg

hyperscan/src/hs_internal.h

Lines 75 to 84 in c00683d

	#define HS_FLAG_ALL ( HS_FLAG_CASELESS \
	| HS_FLAG_DOTALL \
	| HS_FLAG_MULTILINE \
	| HS_FLAG_UTF8 \
	| HS_FLAG_UCP \
	| HS_FLAG_PREFILTER \
	| HS_FLAG_SINGLEMATCH \
	| HS_FLAG_ALLOWEMPTY \
	| HS_FLAG_SOM_LEFTMOST)

eg, flag HS_FLAG_COMBINATION failed to pass check and throw an Unrecognised flag exception

hyperscan/src/compiler/compiler.cpp

Lines 180 to 183 in c00683d

	if (flags & ~HS_FLAG_ALL) {
	DEBUG_PRINTF("Unrecognised flag, flags=%u.\n", flags);
	throw CompileError("Unrecognised flag.");
	}

[fatchanghao]

I think this failure won't happen, actually HS_FLAG_COMBINATION is not a Regex flag, and in function addExpression() the logical expression will be bypassed (line 286-323) before constructing a ParsedExpression object (line 332), so in ParsedExpression constructor it should only check Regex flags.
Did you meet a case that ran into this problem?

[foxever]

I think this failure won't happen, actually HS_FLAG_COMBINATION is not a Regex flag, and in function addExpression() the logical expression will be bypassed (line 286-323) before constructing a ParsedExpression object (line 332), so in ParsedExpression constructor it should only check Regex flags.
Did you meet a case that ran into this problem?

more specifically, hs_expression_info(..., HS_FLAG_COMBINATION ...) -> hs_expression_info_int -> ParsedExpression ctor

in the doc hs_expression_info, HS_FLAG_COMBINATION is a valid flag to call hs_expression_info. is this a valid usage for this api?

[fatchanghao]

I think this failure won't happen, actually HS_FLAG_COMBINATION is not a Regex flag, and in function addExpression() the logical expression will be bypassed (line 286-323) before constructing a ParsedExpression object (line 332), so in ParsedExpression constructor it should only check Regex flags.
Did you meet a case that ran into this problem?

more specifically, hs_expression_info(..., HS_FLAG_COMBINATION ...) -> hs_expression_info_int -> ParsedExpression ctor

in the doc hs_expression_info, HS_FLAG_COMBINATION is a valid flag to call hs_expression_info. is this a valid usage for this api?

This API should also bypass HS_FLAG_COMBINATION, we will fix it, thanks for reporting!

[hongyang7]

Please refer to latest develop branch.