tests: style: Write a check that makes sure that all text files end with a newline

[johnandersen777]

[Pratikrocks]

Hi @pdxjohnny in this issue do we need to check weather the source files like CSV or SQL are ending with a new line or right ?

[johnandersen777]

@Pratikrocks "source" in this case means source code, so .rst, .py, .js, .md, .toml, .cfg, etc. Anything that's text.

[Pratikrocks]

Okay @pdxjohnny :)

[Pratikrocks]

@pdxjohnny there are a large number of files currently which are not ending with a new line take for example this files last line FILE

similarly, several files are there so should we add a new line to all such files and then write a pytest for checking a newline in other files?

[johnandersen777]

@Pratikrocks

There are a large number of files currently which are not ending with a new line take for example this files last line FILE

We want to check if the last byte in the file is b"\n"

similarly, several files are there so should we add a new line to all such files and then write a pytest for checking a newline in other files?

Good plan! Let's add it under tests/test_style.py

[Pratikrocks]

Okay then am just adding an extra "\n" to pre-existing files ( excluding files hidden dirs and binaries) and then modifying the test/test_styles.py

[johnandersen777]

You can use the IngoreFile class in tests/test_ci.py to make sure you aren't getting anything that's in a .gitignore, and then pathlib.Path.rglob to grab all the files.

• First open a PR with the test implemented.

• Then add the newline byte where required in a spertate commit after you see that the test you added caused the CI to fail, and then the CI run for the test where you add the byte to each file it's missing from will cause the CI to pass.