[MBL-17725][Student] Grade screen design changes #3230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges # Conflicts: # apps/parent/src/main/java/com/instructure/parentapp/di/feature/GradesModule.kt # apps/student/src/main/java/com/instructure/student/util/StudentPrefs.kt
andrasmaczak
approved these changes
Sep 5, 2025
kdeakinstructure
requested changes
Sep 5, 2025
There was a problem hiding this comment.
QA Findings:
- No animation when expand/collapse assignment groups (whether it's grouped by due date or 'type'). I know it's the same in Parent (we don't have animation there as well), but it would be better to have it in both apps just like we did in the Student.
- Grading period is not showed anymore on the Grades screen. It was used to in Student, but it's not showed in Parent as well, but I can see on the design and I think it would be better if we would show it in the Student app. See attached screenshot, which I've found in Figma, which was 'randomly' there and it's about the old design. However, I still think we should not loose to show this important information in Student app.
- We lost the 'Add Bookmark' functionality, it used to be available on the Grades screen but now it isn't. (It's not even on the design but I'm not sure if it's good to remove functionality from the users, especially bookmarking a frequently visited page)
|
Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
kristofnemere
changed the base branch from
master
to
student-grades-redesign
|
Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
kristofnemere
deleted the
MBL-17725-Implement-grade-screen-design-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan:
refs: MBL-17725
affects: Student
release note: Grades screen design update.
Checklist