Second attempt to submit RAG repo location ADR because the last one failed #165
Conversation
… github Signed-off-by: Bill Murdock <[email protected]>
jwm4
changed the title
cdoern
left a comment
cdoern
left a comment
There was a problem hiding this comment.
I agree with the conclusion to put this in instructlab/instructlab for the time being, left a few other comments.
|
|
||
| ## Decision | ||
|
|
||
| - For now, RAG will be located in the core repository in its own directory: `src/instructlab/rag` in the core InstructLab repository (<https://github.com/instructlab/instructlab>). |
|
|
||
| ### Future phases | ||
|
|
||
| - In the near future, RAG might be moved to the existing <https://github.com/instructlab/rag> repository. |
There was a problem hiding this comment.
I'd like to (maybe in a separate doc or a future PR to this doc) to figure out why we'd move it out. If we are just moving things to separate into units, I think you can have a clearly defined unit inside of the core repo.
There was a problem hiding this comment.
For the purposes of this document, I think the pros and cons of listed for alternatives is probably sufficient. I don't think we need a stronger argument for a thing we might do in the future since we're explicitly committing to open a new ADR if and when we do.
|
|
||
| ## Risks | ||
|
|
||
| - Putting the RAG functionality in the core repository requires any application that wants to use this functionality to bring in the entire core which then brings in all of the libraries it depend on, so this becomes an enormous dependency. This discourages reuse in other applications. It *encourages* either of the following behaviors that would be unfortunate: |
There was a problem hiding this comment.
realistically though, no one is using RAG for ilab without ilab
There was a problem hiding this comment.
I disagree, but let's try to resolve that disagreement in another venue.
Signed-off-by: Bill Murdock <[email protected]>
|
Discussed this in the oversight committee and this is approved. |
4 participants
#163 failed due to some github / DCO problem, so we're trying again.