-
Notifications
You must be signed in to change notification settings - Fork 53
Open
Description
Setting up an environment for the first time (following https://insitro.github.io/redun/developing.html) directly on the host has quite a few setbacks:
make setup- does not install/check for Java, needed for some federated/spark tests, installed implicitly in Ubuntu but not in Debian; this is not mentioned
- need to find python3.10 or older, when package manager might have only 3.11
- docs outdated; makefile rules
make mypyand some others no longer exist. If this was a single entry script, docs would not need update as often
I see you already use docker-compose for the database, both in tests and examples. Why not use a docker/compose container to run the tests & examples too? The packaged dockerfile could serve as example for anyone trying to adapt it to their own hosts / containers.
So a new developer could just run ./pytest.sh -k filter --pdb and test what they are trying to patch in 5min, with 100% parity on the CI
I have a PR with some example scripts to start a discusison
Metadata
Metadata
Assignees
Labels
No labels