Skip to content

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented May 7, 2025

Closes #296

Test by running all the module examples to check if they look alright

@vedhav vedhav added the core label May 7, 2025
Copy link
Contributor

github-actions bot commented May 7, 2025

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             247     247  0.00%    83-362
R/tm_g_ae_sub.R               310     310  0.00%    60-405
R/tm_g_butterfly.R            383     383  0.00%    124-546
R/tm_g_decorate.R              47      47  0.00%    18-99
R/tm_g_events_term_id.R       294     294  0.00%    63-394
R/tm_g_heat_bygrade.R         315     315  0.00%    135-485
R/tm_g_patient_profile.R      712     712  0.00%    157-936
R/tm_g_spiderplot.R           337     337  0.00%    99-482
R/tm_g_swimlane.R             368     368  0.00%    126-550
R/tm_g_waterfall.R            441     441  0.00%    108-604
R/utils.R                      50      45  10.00%   32-91, 125-155
R/zzz.R                         3       3  0.00%    4-7
TOTAL                        3507    3502  0.14%

Diff against main

Filename                    Stmts    Miss  Cover
------------------------  -------  ------  --------
R/tm_g_heat_bygrade.R          -2      -2  +100.00%
R/tm_g_patient_profile.R       -1      -1  +100.00%
R/tm_g_spiderplot.R            +6      +6  +100.00%
R/tm_g_swimlane.R              -3      -3  +100.00%
R/utils.R                      +3      +3  -0.64%
TOTAL                          +3      +3  -0.00%

Results for commit: 4eb3206

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented May 7, 2025

Unit Tests Summary

 1 files   1 suites   0s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit 4eb3206.

♻️ This comment has been updated with latest results.

@vedhav vedhav enabled auto-merge (squash) May 23, 2025 02:55
@llrs-roche llrs-roche self-assigned this May 23, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shiny app looks good. I don't see any issue with the code modified (checks, remaining css file, print(plot)).
While checking tm_g_spiderplot I noticed the examples generates some warnings:

Warning: Removed 798 rows containing missing values or values outside the scale range
(`geom_line()`).

Maybe this is for another issue or not as the check runs fine without problems.

@vedhav vedhav merged commit 7a12a17 into main May 23, 2025
29 checks passed
@vedhav vedhav deleted the 296-switch-to-bslib@main branch May 23, 2025 11:27
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to bslib
2 participants