Skip to content

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Mar 5, 2024

Pull Request

Fixes #1092

@edelarua edelarua added the sme label Mar 5, 2024
@edelarua edelarua enabled auto-merge (squash) March 5, 2024 00:24
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Unit Tests Summary

  1 files   33 suites   2s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit 0a4fef8.

♻️ This comment has been updated with latest results.

@shajoezhu
Copy link
Contributor

hi @edelarua , I was wondering, if you could change the snapshot a little, just make it fail. I was wondering if the snapshot test is actually ran by the cicd pipeline.

Signed-off-by: Emily de la Rua <[email protected]>
@edelarua
Copy link
Contributor Author

edelarua commented Mar 5, 2024

hi @edelarua , I was wondering, if you could change the snapshot a little, just make it fail. I was wondering if the snapshot test is actually ran by the cicd pipeline.

@shajoezhu I believe the snapshot tests aren't run for PRs since these checks never fail until tested in the integration tests

Signed-off-by: Emily de la Rua <[email protected]>
@shajoezhu
Copy link
Contributor

hi @edelarua , I was wondering, if you could change the snapshot a little, just make it fail. I was wondering if the snapshot test is actually ran by the cicd pipeline.

@shajoezhu I believe the snapshot tests aren't run for PRs since these checks never fail until tested in the integration tests

thanks a lot @edelarua for confirming. I had also followed up with @cicdguy before, and these will be resolve in coming weeks, we will need these snapshot test ran on gh cicd

@cicdguy
Copy link
Contributor

cicdguy commented Mar 6, 2024

Indeed. We'll have both CRAN as well as non-CRAN runs enabled on all repos soon.

Copy link
Contributor

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @edelarua

@edelarua edelarua merged commit b5e8dc0 into main Mar 7, 2024
@edelarua edelarua deleted the 1092_fix_tests@main branch March 7, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update snapshots to fix tests
4 participants