[Etcm 521] Fast sync integration tests #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinraju
commented
Mar 22, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/fast/FastSync.scala
Outdated
Show resolved
Hide resolved
robinraju
force-pushed
the
ETCM-521-integration-tests
branch
from
9f1e8ff to
bd77cd1
Compare
robinraju
force-pushed
the
ETCM-521-integration-tests
branch
from
9c2080c to
39ab6b1
Compare
AnastasiiaL
reviewed
Mar 25, 2021
AnastasiiaL
reviewed
Mar 25, 2021
- Apply fix for branch resolving not being started
robinraju
force-pushed
the
ETCM-521-integration-tests
branch
from
39ab6b1 to
9ae6a32
Compare
jvdp
approved these changes
Mar 29, 2021
Contributor
jvdp
left a comment
jvdp
left a comment
There was a problem hiding this comment.
LGTM 👍
Did raise some questions, and I think more comments/descriptions would be nice to have for FakePeer DSL.
| } | ||
| } | ||
|
|
||
| it should "switch to regular sync once `safeDownloadTarget` is reached" in customTestCaseResourceM( |
Contributor
There was a problem hiding this comment.
Where do you assert that regular sync was initiated?
Contributor
Author
There was a problem hiding this comment.
the CommonFakePeer#waitForFastSyncFinish() helper method checks for the completion of Fastsync. More specific assertion can be made possible by intercepting the logs only. Maybe something to improve in another ticket to add support for intercepting logs in tests.
milenkara
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for the newly introduced fast sync improvements (Concurrent download of headers)
Important Changes Introduced
Minor fixes were applied to the original implementation of
FastSync, which prevented the branch resolution from being completed properly.Testing
Run the tests and look through the logs for branch resolution when a malicious master peer is found.