[ETCM-556] Add a metric for the total time it takes for FastSync to complete and update docker-compose Grafana dashboard #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-bogastry
requested review from
AnastasiiaL,
bsuieric,
jvdp,
robinraju and
ten15bit
dzajkowski
reviewed
Jan 28, 2021
src/main/scala/io/iohk/ethereum/blockchain/sync/fast/FastSync.scala
Outdated
Show resolved
Hide resolved
leo-bogastry
force-pushed
the
feature/ETCM-556-add-fastsync-total-time-metric
branch
3 times, most recently
from
e1cca47 to
e311c6c
Compare
…omplete and update docker-compose Grafana dashboard
leo-bogastry
force-pushed
the
feature/ETCM-556-add-fastsync-total-time-metric
branch
from
e311c6c to
93b8296
Compare
jvdp
approved these changes
Jan 28, 2021
bsuieric
approved these changes
Jan 28, 2021
leo-bogastry
deleted the
feature/ETCM-556-add-fastsync-total-time-metric
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is help measuring FastSync performance.
A previous PR with more metrics was opened: #905
Proposed Solution
A new metric called
fastsync.totaltime.minutes.gaugewas added to record the amount of minutes elapsed since the start until the finish of StartSync.Remarks
Waiting for FastSync to complete takes a really long time with the current available networks, so this was not tested the way I would like to.
Screenshot of a dummy value:
