[ETCM-174] Sorting of checkpoint signatures #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtkaczyk
added
BREAKS PROTOCOL
Contributor
|
What if we sorted the sigs ourselves in |
Contributor
Author
|
that's right, will do the update |
Contributor
Author
|
waiting for #728 |
Contributor
|
After margin [ETCM-141] scalafmt . This PR can be updated by git merge |
pslaski
force-pushed
the
etcm-174-validate-lexicographically-signatures
branch
3 times, most recently
from
e3c7ca3 to
8a69185
Compare
ntallar
requested changes
Oct 23, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
Only a really minor change and LGTM! Should we document this change on our checkpointing spec?
src/main/scala/io/iohk/ethereum/consensus/validators/BlockWithCheckpointHeaderValidator.scala
Show resolved
Hide resolved
Contributor
Author
|
I will update docs after merge |
rtkaczyk
approved these changes
Oct 23, 2020
pslaski
force-pushed
the
etcm-174-validate-lexicographically-signatures
branch
from
8a69185 to
8ce96d7
Compare
rtkaczyk
removed
BREAKS PROTOCOL
ntallar
added
the
BREAKS PROTOCOL
ntallar
approved these changes
Oct 23, 2020
ntallar
left a comment
ntallar
left a comment
There was a problem hiding this comment.
LGTM!
.\\ //.
. \ \ / /.
.\ ,\ /` /,.-
-. \ /'/ / .
` - `-' \ -
'. /.\`
- .-
:`//.'
.`.'
.' BP
pslaski
force-pushed
the
etcm-174-validate-lexicographically-signatures
branch
from
8ce96d7 to
c515106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sort checkpoint signatures lexicographically to prevent having the same checkpoint block with a different hash (different order of signatures).
Remember about changes on OBFT node side.
Important Changes Introduced