Skip to content

Conversation

@CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Oct 24, 2018

Signed-off-by: Alexander Diemand [email protected]

This PR adds the --log-console-off cli argument that the node will not log to stdout.

YT: DEVOPS-1109
cardano-sl PR: input-output-hk/cardano-sl#3785

Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • [~] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

nikolaglumac and others added 9 commits October 17, 2018 11:19
…us-notification-close-button-hover-color

[DDW-443] Fix Antivirus Notification Close Button Hover Color
[DEVOPS-1096] Fix Daedalus icon on Linux
[DEVOPS-1095] allow opening links when in the sandbox
…s-and-cardano-version-to-daedalus-logs

[DDW-445] Add Daedalus and Cardano version to Daedalus logs
@CodiePP CodiePP self-assigned this Oct 24, 2018
@CodiePP CodiePP changed the title Adiemand/devops 1109/inhibit console log [DEVOPS-1109] cli argument to inhibit console log: --log-console-off Oct 24, 2018
@CodiePP
Copy link
Contributor Author

CodiePP commented Oct 24, 2018

this output file was once removed in PR #1027

@CodiePP
Copy link
Contributor Author

CodiePP commented Oct 24, 2018

verified on Linux:

2211 pts/1    Sl+    0:21 cardano-node --tlsca /home/user/.local/share/Daedalus/mainnet/tls/server/ca.crt --tlscert /home/user/.local/share/Daedalus/mainnet/tls/server/server.crt --tlskey /home/user/.local/share/Daedalus/mainnet/tls/server/server.key --no-client-auth \
   --log-console-off  \
   --update-server https://update-cardano-mainnet.iohk.io --keyfile /home/user/.local/share/Daedalus/mainnet/Secrets/secret.key --topology /nix/var/nix/profiles/profile-mainnet/etc/wallet-topology.yaml --wallet-db-path /home/user/.local/share/Daedalus/mainnet/Wallet --update-latest-path /home/user/.local/share/Daedalus/mainnet/installer.sh --wallet-address 127.0.0.1:0 --update-with-package --report-server http://report-server.cardano-mainnet.iohk.io:8080 --db-path /home/user/.local/share/Daedalus/mainnet/DB/ --log-config /nix/var/nix/profiles/profile-mainnet/etc/log-config-prod.yaml --logs-prefix /home/user/.local/share/Daedalus/mainnet/Logs --configuration-file /nix/var/nix/profiles/profile-mainnet/etc/configuration.yaml --configuration-key mainnet_wallet_linux64

^^ line breaks introduced; the flag --log-console-off is present!

@CodiePP CodiePP force-pushed the adiemand/DEVOPS-1109/inhibit-console-log branch from bdfcbaa to a008ad4 Compare October 24, 2018 15:20
@CodiePP
Copy link
Contributor Author

CodiePP commented Oct 24, 2018

will have to reopen it against release/0.12.0

@CodiePP CodiePP closed this Oct 24, 2018
@nikolaglumac nikolaglumac deleted the adiemand/DEVOPS-1109/inhibit-console-log branch October 24, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants