Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Conversation

@rvl
Copy link
Contributor

@rvl rvl commented Dec 6, 2018

Description

Fix faucet withdrawals which occasionally fail due to unavailable UTxO.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1172

Type of change

  • Bug fix in faucet -- i.e. testnet only.

Testing

This is done with a local build with a faucet connected to the local Daedalus wallet.

  • Successful withdrawals with a local faucet and wallet.
  • Withdrawal transaction does not result in grouping of UTxO. See transaction in explorer

@rvl rvl requested review from a team and commandodev December 6, 2018 07:49
Copy link
Contributor

@commandodev commandodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rvl
Copy link
Contributor Author

rvl commented Dec 6, 2018

Thanks

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 6, 2018
3934: [DEVOPS-1172] faucet: Use OptimizeForHighThroughput grouping policy r=rvl a=rvl

## Description

Fix faucet withdrawals which occasionally fail due to unavailable UTxO.

## Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1172



Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 6, 2018

@iohk-bors iohk-bors bot merged commit 46dc932 into release/2.0.0 Dec 6, 2018
@iohk-bors iohk-bors bot deleted the devops-1172-faucet-transactions branch December 6, 2018 13:52
iohk-bors bot added a commit that referenced this pull request Dec 21, 2018
3972: Cherry-picks from release/2.0.0 branch to develop r=rvl a=rvl

These are cherry-picks of the PRs: #3811 #3816 #3817 #3831 #3846 #3867 #3879 #3883 #3919 #3934 #3936 #3946 #3962.

Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: Karl Knutsson <[email protected]>
Co-authored-by: Michael Hueschen <[email protected]>
Co-authored-by: Alexander Diemand <[email protected]>
Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Rupert Horlick <[email protected]>
Co-authored-by: Luke Nadur <[email protected]>
Co-authored-by: Jordan Millar <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
Co-authored-by: Samuel Leathers <[email protected]>
Co-authored-by: Jean-Christophe Mincke <[email protected]>
@KtorZ KtorZ mentioned this pull request Jan 4, 2019
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants