This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-1126] add required jobset to release.nix #3852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
approved these changes
Nov 13, 2018
Contributor
rvl
left a comment
rvl
left a comment
There was a problem hiding this comment.
Have checked the aggregate jobset in hydra and it looks good.
disassembler
added a commit
that referenced
this pull request
Nov 26, 2018
(cherry picked from commit 54d803e)
iohk-bors bot
added a commit
that referenced
this pull request
Nov 26, 2018
3901: [DEVOPS-1126] add required jobset to release.nix (#3852) r=disassembler a=disassembler (cherry picked from commit 54d803e) ## Description <!--- A brief description of this PR and the problem is trying to solve --> ## Linked issue <!--- Put here the relevant issue from YouTrack --> ## Type of change <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply and `~` in the ones that do not: --> - [ ] 🐞 Bug fix (non-breaking change which fixes an issue) - [ ] 🛠 New feature (non-breaking change which adds functionality) - [ ]⚠️ Breaking change (fix or feature that would cause existing functionality to change) - [ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc - [ ] 🔨 New or improved tests for existing code - [ ] ⛑ git-flow chore (backport, hotfix, etc) ## Developer checklist <!--- A mental checklist for the developer submitting the PR. Put an `x` in all the boxes that apply and `~` in the ones that do not: ---> - [ ] I have read the [style guide](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/style-guide.md) document, and my code follows the code style of this project. - [ ] If my code deals with exceptions, it follows the [guidelines](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/exceptions.md). - [ ] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on [cardanodocs.com](https://github.com/input-output-hk/cardanodocs.com), amending the inline [Haddock](https://www.haskell.org/haddock/) comments, any relevant README file or one of the document listed in the [docs](https://github.com/input-output-hk/cardano-sl/tree/develop/docs) directory. - [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub. ## Testing checklist <!-- If you aren't providing any tests as part of this PR, use this section to state clearly why. It needs to be a strong motivation and definitely the exception, not the rule. --> - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. ## QA Steps <!--- Which are the steps needed to test this feature, if any? --> ## Screenshots (if available) <!--- Upload a GIF, an asciinema video or an image demoing the feature --> ## How to merge Send the message `bors r+` to merge this PR. For more information, see [`docs/how-to/bors.md`](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/how-to/bors.md). Co-authored-by: Samuel Leathers <[email protected]> Co-authored-by: Samuel Leathers <[email protected]>
disassembler
added a commit
that referenced
this pull request
Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a required jobset to release.nix that has constituents of what we currently have for branch protection. This is to reduce the number of notifications we have from hydra.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-1126
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)