This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[RCD-38] Fix "GeneratedSecrets missing" error #3812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An error,
GeneratedSecrets missing from Genesis.Config, is thrown when trying to make use of thecardano-keygentool.It was found that we attempt to extract a
Maybe GeneratedSecretsfrom the config (and throw if it isNothing) before we even know which command was specified by the user. Because theconfigGeneratedSecretsfield is always set toNothingin theGCSrccase, the error will always be thrown whenever trying to make use ofcardano-keygenwith a config which makes use of aGCSrc.Therefore, the solution would be that, since
GeneratedSecretsis only required for thegenerate-keys-by-speccommand, we should only attempt to extractGeneratedSecretsin theGenerateKeysBySpeccase. This also means that thegenerate-keys-by-speccommand can only be used with a config which makes use of aGCSpec.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/RCD-38
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)