Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Conversation

@kderme
Copy link
Member

@kderme kderme commented Oct 12, 2018

Description

This pr has two parts:

  • The first part is a bug fix (CBR-466). When we ask for addresses during restoration, even after a tx that uses an address is discovered, the address is still reported as unused. This happens because currently only partial checkpoints are queried and historical checkpoint are ignored. The first commit of this pr solves this issue.

  • The second part is more of an improvement that was not provided by the old wallet (CBR-193). When we discover a utxo at the begining of restoration, we mark the relevant addresses as used. This means that some addresses are reported as used, even before the tx that uses them is discovered.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CBR-193
https://iohk.myjetbrains.com/youtrack/issue/CBR-466

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Start a restoration. When a tx of the wallet is discovered and before restoration finishes, use endpoint api/v1/addresses. The addresses of the tx should all be used:true

Screenshots (if available)

@kderme kderme changed the title [CBR-193] fix address reported as unused during restoration [CBR-466] fix address reported as unused during restoration Oct 15, 2018
@kderme kderme added the wip label Oct 15, 2018
@kderme kderme removed the wip label Oct 16, 2018
@kderme kderme requested a review from KtorZ October 27, 2018 12:04
@KtorZ KtorZ changed the base branch from develop to release/2.0.0 October 30, 2018 09:30
@KtorZ KtorZ merged commit 615970a into release/2.0.0 Oct 30, 2018
@KtorZ KtorZ deleted the kderme/CBR-193 branch October 30, 2018 10:19
@KtorZ KtorZ restored the kderme/CBR-193 branch October 30, 2018 10:19
@KtorZ KtorZ mentioned this pull request Jan 4, 2019
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants