This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-246] Implement getInfo with the new data layer #3495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsko
suggested changes
Aug 28, 2018
Contributor
edsko
left a comment
edsko
left a comment
There was a problem hiding this comment.
LGTM. Minor correction on dealing with core.
lib/src/Pos/Context/Context.hs
Outdated
| , ConnectedPeers(..) | ||
|
|
||
| -- * Lenses | ||
| , ncLastKnownHeader_L |
Contributor
There was a problem hiding this comment.
No need to export this. Just use lensOf, following the same pattern as the other HasLens instances.
Contributor
Author
There was a problem hiding this comment.
For some reason it didn't work out of the box. Let me try.
adinapoli-iohk
deleted the
adinapoli/feature/cbr-246-hook-sync-progress-to-info-api
branch
KtorZ
pushed a commit
that referenced
this pull request
Nov 9, 2018
…46-hook-sync-progress-to-info-api [CBR-246] Implement getInfo with the new data layer
KtorZ
pushed a commit
to input-output-hk/cardano-wallet-legacy
that referenced
this pull request
Nov 9, 2018
…hk/adinapoli/feature/cbr-246-hook-sync-progress-to-info-api [CBR-246] Implement getInfo with the new data layer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR wires the
getInfowith some real logic allowing us to fully implement/api/v1/node-infousing the new data layer.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-246
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)