fix: [lw-12138] handle disconnected ledger wallet error #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceahasegan
previously approved these changes
Jan 29, 2025
rhyslbw
reviewed
Jan 29, 2025
|
|
||
| try { | ||
| await transport.close(); | ||
| } catch { |
There was a problem hiding this comment.
Can the error be inspected to ensure it's the expected failure before ignoring?
vetalcore
force-pushed
the
fix/lw-12138-handle-disconnected-ledger-wallet-error
branch
from
49550e3 to
638b866
Compare
rhyslbw
approved these changes
Jan 30, 2025
mirceahasegan
approved these changes
Jan 30, 2025
vetalcore
deleted the
fix/lw-12138-handle-disconnected-ledger-wallet-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There are multiple
Failed to execute 'releaseInterface' on 'USBDevice'issues reported by sentry.Further investigation confirmed that
hw-transport-webusbpackage also attaches a disconnect event listener while creating a Ledger transport, so we might end up trying to handle disconnection multiple times.Proposed Solution
Wrap
transport.closecall in the on disconnect handler with a try catch clause.Important Changes Introduced