-
Notifications
You must be signed in to change notification settings - Fork 63
feat: dockerize blockfrost-ryo #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
2a1d325
to
820d241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ginnun , some comments aimed to better integrate this task in our docker compose infrastructure.
22df817
to
6f46246
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have alot of experience in this. Maybe someone else would be better suited to review this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor things, not sure if there is anything to do about them. Other than that it looks good
SUBMIT_API_URL: ${SUBMIT_API_URL:-http://cardano-submit-api:8090/} | ||
USE_BLOCKFROST: ${USE_BLOCKFROST:-false} | ||
USE_SUBMIT_API: ${USE_SUBMIT_API:-false} | ||
ASSET_PROVIDER: ${ASSET_PROVIDER:-dbsync} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that we are using microservice asset provider it probably should default to it, not sure if it needs to be changed since API is the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I selected this default based on the default behaviour in the code.
If USE_TYPEORM_ASSET_PROVIDER
is true, ASSET_PROVIDER
selection will be ignored.
d823d16
to
d548040
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Context
Proposed Solution
We modified the blockfrost-ryo to support custom networks. This solution dockerizes the modified version.
https://input-output.atlassian.net/browse/LW-11387