You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! 👋
I'm a maintainer of the html-eslint plugin, which brings HTML linting support to ESLint.
While exploring the ing-bank/lion project, I tried applying html-eslint and found that it works well here. This PR adds HTML linting and includes a few fixes based on the results — such as adding missing type="button" to buttons (to prevent unintended form submissions) and removing unnecessary whitespace.
If this seems useful, I’d be happy to discuss further or help tune the lint rules for your setup. Would you be interested? 😊
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yeonjuan
requested review from
tlouisse,
gerjanvangeest,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
What I did
Hi! 👋
I'm a maintainer of the html-eslint plugin, which brings HTML linting support to ESLint.
While exploring the ing-bank/lion project, I tried applying html-eslint and found that it works well here. This PR adds HTML linting and includes a few fixes based on the results — such as adding missing type="button" to buttons (to prevent unintended form submissions) and removing unnecessary whitespace.
If this seems useful, I’d be happy to discuss further or help tune the lint rules for your setup. Would you be interested? 😊