fix: remove unnecessary _showOverlayCondition

[maxevilmind]

Found a behavior that seems unintended. As far as I can say from code comments and overall familiarity with logic, _showOnverlayCondition is intended to be called only on keyUp. Looks like calling it in a _textboxOnInput is unnecessary and it will cause some weird edge-cases when subclassers override _showOnverlayCondition. This is due to difference in how _showOnverlayCondition is parametrized when called on keyUp (with an ev keyboard event) and in _textboxOnInput (with {}).

Scenario which breaks without the proposed change:
A subclasser wants to implement a functionatily when overlay will only show if input length is >= 3.
They would override a method like this:

_showOverlayCondition(options) {
    const hideOnKeys = ['Tab', 'Escape', 'Enter'];
    if (this.minSearchChars && !hideOnKeys.includes(options.lastKey)) {
      return options.currentValue?.length >= this.minSearchChars;
    } else {
      return super._showOverlayCondition(options);
    }
  }

In runtime _showOverlayCondition method would be called twice, seemingly on keyDown and keyUp but upon closer look, first call comes from _textboxOnInput.
As _showOverlayCondition first call will come from _textboxOnInput, options will equal { } and it will close overlay and set input value of textbox to ''.

It looks logical to me to get rid of this line. Tests pass.

[changeset-bot]

⚠️ No Changeset found

Latest commit: acae80c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[okadurin]

Hi @maxevilmind, thank you for the contribution! Could you add a test that fails with the current setup?

[maxevilmind]

Hi @okadurin !
Yeah, I will add a test when I have a spare moment.