[LionSelectRich] disabled options should not get focus

[gerjanvangeest]

Expected behavior

I would expect a disabled option to be skipped when navigating with the keyboard, as happens in a native select.

Actual Behavior

When an option is disabled it can still receive keyboard focus, and can be clicked upon via [Enter].

[shiralizadeh]

I'll start working on this.

[shiralizadeh]

@gerjanvangeest Can you explain more on the case? Which browser version? Can you share a screenshot/video?
I've tried on Chrome 137 and Safari 18.5 on Mac, it works fine.

[gerjanvangeest]

The error occurs if a single option is disabled, not the whole select.

Tested on Chrome v137 on a Mac.

[danielnagercarpio]

Hello!
I'm currently looking for a job, and I came across a solution for this issue.
Would it be okay if I opened a pull request?

[shiralizadeh]

@Dozom Nice!

[danielnagercarpio]

@shiralizadeh
Hey, I noticed that some tests started failing after the pull request:

❌ integration with ListboxMixin > ListboxMixin > Interactions > Disabled Options > does not skip disabled options but prevents checking them
❌ integration with ListboxMixin > ListboxMixin > Interactions > Disabled Options > does not check disabled options when selection-follow-focus is enabled

To be honest, I'm not sure how to solve this yet - it's only my second contribution to open source. I did see that these tests are coming from: lion-select-listbox-suite-integration.test.js, so hopelly that helps.

Open to any suggestions — thanks!

[shiralizadeh]

@Dozom I can help you with it. Will check them soon and let you know.

[danielnagercarpio]

@shiralizadeh Thanks a lot, I really appreciate it. I’ll be waiting.