Tracing fixes for error span #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd7lxl
approved these changes
Nov 19, 2021
| func AddErrorSpan(span *trace.Span, err error) error { | ||
| var code int32 = trace.StatusCodeUnknown | ||
| var code int32 = trace.StatusCodeOK | ||
| status, ok := status.FromError(err) |
There was a problem hiding this comment.
The reuse of status here from module to variable makes the code harder to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for adding error spans caused by bug in open telemetry collector.
See discussion here: open-telemetry/opentelemetry-collector#70
codeshould be added as acensus.status_codetag.messageshould be added as acensus.status_descriptiontag.errortag with valuetrue