-
Notifications
You must be signed in to change notification settings - Fork 5.7k
chore(deps): Switch to maintained yaml library #17610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@mstrandboge Thanks for the update! This PR upgrades to v2, which seems like the safest migration path. I just wanted to note that there’s also a newer version available (gopkg.in/yaml.v4). |
5450ba8
to
abf3932
Compare
@skartikey There is a v4 though it currently only is in release candidates. I can update us to the v3 in the mean time and keep an eye on this for the future |
@mstrandboge Yes, please. That's a good plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mstrandboge Thanks!
2ee296c
to
c2d87e6
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
Moves from
gopkg.in/yaml.v2
togo.yaml.in/yaml/v2
The libraries are the same, but the old name had its repo deprecated and its version pinned at 2.4.0: https://github.com/go-yaml/yaml/tree/v2.4.0
The new library is located here on github: https://github.com/yaml/go-yaml/tree/v2/
Checklist
Related issues
resolves #