Skip to content

Conversation

@karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Aug 14, 2024

Proposed Changes

  • Also add headers field to InfluxDBError (headers are already in rest.py class ApiException).
  • Add asserts for headers in existing tests
  • Add test of headers field
  • Add http_error_handling.py example

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested a review from bednar August 14, 2024 11:47
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (45e6607) to head (db7df20).
Report is 9 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   90.43%   90.47%   +0.03%     
==========================================
  Files          40       40              
  Lines        3524     3526       +2     
==========================================
+ Hits         3187     3190       +3     
+ Misses        337      336       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

LGTM 🚀

@bednar bednar added this to the 1.46.0 milestone Aug 21, 2024
@bednar bednar merged commit 7ad9533 into master Aug 21, 2024
@bednar bednar deleted the feat/errorHeaders branch August 21, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants