Skip to content

fix: retain semver symbols on snapshot update #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2018
Merged

fix: retain semver symbols on snapshot update #191

merged 1 commit into from
Mar 15, 2018

Conversation

@tabrindle
Copy link
Contributor

Previously, this rule would update semver to "8.10.0" on solidarity snapshot, rather than the expected "~8.10.0".

"Node": [
      {
        "rule": "cli",
        "binary": "node",
        "semver": "~8.9.4",
     }
]

@GantMan
Copy link
Member

GantMan commented Mar 15, 2018

Windows tests seem unrelated.

@GantMan GantMan merged commit fe99160 into master Mar 15, 2018
@GantMan GantMan deleted the bugfix/retain-semver branch March 15, 2018 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tabrindle @GantMan