Skip to content

Conversation

@tabrindle
Copy link
Contributor

Envinfo needed to output a commonjs bundle to be imported this way. In the future I might make a selection of different bundles.

I also needed to add a main entry in package.js, and have two entries in the dist/ folder - one for the main library and one for the cli.

While I was at it, I got rid of the extra import we had in report, and just used envinfo from context.

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files          33       33           
  Lines         629      629           
  Branches      107      107           
=======================================
  Hits          508      508           
  Misses         83       83           
  Partials       38       38
Impacted Files Coverage Δ
src/extensions/functions/solidarityReport.ts 88.88% <100%> (ø) ⬆️
src/extensions/solidarity-extension.ts 86.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 915b12e...3eaa456. Read the comment docs.

@tabrindle tabrindle requested a review from GantMan March 8, 2018 18:17
@tabrindle
Copy link
Contributor Author

Im such an idiot, don't merge this yet.

@GantMan
Copy link
Member

GantMan commented Mar 9, 2018

Hahahah ok. BTW, I should be grabbing helpers off of context now. That way I only have to change it in one spot.

@tabrindle tabrindle changed the title upgrade envinfo to 4.0.1 upgrade envinfo to 4.3.1 Mar 15, 2018
@GantMan
Copy link
Member

GantMan commented Mar 15, 2018

Do you have to change the name of .envInfo to .envInfoHelpers? I think it's best to keep the name bc theres 1 plugin that expects it to be named that.

- Per discussion: Let’s not break things until a major version bump to keep casing consistent with envinfo package.
@tabrindle
Copy link
Contributor Author

Don't have to - but per discussion let's save making casing consistent until another time when we make a breaking change. It's mostly just preference. ¯_(ツ)_/¯

@GantMan GantMan merged commit 6f6a881 into master Mar 18, 2018
@GantMan GantMan deleted the chore/upgrade-envinfo-4.0.1 branch March 18, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants