Skip to content

Fix up gluegun version and colors and all deps upgraded #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 19, 2018
Merged

Fix up gluegun version and colors and all deps upgraded #164

merged 5 commits into from
Jan 19, 2018

Conversation

@GantMan
Copy link
Member

@GantMan GantMan commented Jan 19, 2018

colors were barking bc print.color has been removed.

This also updates dependencies all around.

@GantMan GantMan changed the title Fix up gluegun version and colors Fix up gluegun version and colors and all deps upgraded Jan 19, 2018
@TravisBuddy
Copy link
Contributor

TravisBuddy commented Jan 19, 2018

Travis tests have failed

Hey Gant Laborde,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci 
> [email protected] test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
FAIL __tests__/command_helpers/checkCLIForUpdates.ts
  ● checkCLIForUpdates › with a good binary › pads zeros for non-semver versions

    TypeError: Cannot read property 'green' of undefined
      
      at src/extensions/functions/checkCLIForUpdates.ts:26:25
          at Generator.next (<anonymous>)
      at fulfilled (src/extensions/functions/checkCLIForUpdates.ts:3:56)
          at <anonymous>

PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/schema/validateExampleSchema.ts

Summary of all failing tests
FAIL __tests__/command_helpers/checkCLIForUpdates.ts
  ● checkCLIForUpdates › with a good binary › pads zeros for non-semver versions

    TypeError: Cannot read property 'green' of undefined
      
      at src/extensions/functions/checkCLIForUpdates.ts:26:25
          at Generator.next (<anonymous>)
      at fulfilled (src/extensions/functions/checkCLIForUpdates.ts:3:56)
          at <anonymous>


Test Suites: 1 failed, 27 passed, 28 total
Tests:       1 failed, 125 passed, 126 total
Snapshots:   27 passed, 27 total
Time:        10.885s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test:ci: `jest --ci --runInBand && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-01-19T22_55_50_248Z-debug.log

yarn danger ci 
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
No issues or messages were sent. Removing any existing messages.
Done in 2.95s.

Node.js: 8

npm run test:ci 
> [email protected] test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
FAIL __tests__/command_helpers/checkCLIForUpdates.ts
  ● checkCLIForUpdates › with a good binary › pads zeros for non-semver versions

    TypeError: Cannot read property 'green' of undefined
      
      at src/extensions/functions/checkCLIForUpdates.ts:26:25
          at Generator.next (<anonymous>)
      at fulfilled (src/extensions/functions/checkCLIForUpdates.ts:3:56)
          at <anonymous>

PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/schema/validateExampleSchema.ts

Summary of all failing tests
FAIL __tests__/command_helpers/checkCLIForUpdates.ts
  ● checkCLIForUpdates › with a good binary › pads zeros for non-semver versions

    TypeError: Cannot read property 'green' of undefined
      
      at src/extensions/functions/checkCLIForUpdates.ts:26:25
          at Generator.next (<anonymous>)
      at fulfilled (src/extensions/functions/checkCLIForUpdates.ts:3:56)
          at <anonymous>


Test Suites: 1 failed, 27 passed, 28 total
Tests:       1 failed, 125 passed, 126 total
Snapshots:   27 passed, 27 total
Time:        13.496s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test:ci: `jest --ci --runInBand && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-01-19T22_56_07_316Z-debug.log

yarn danger ci 
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
No issues or messages were sent. Removing any existing messages.
Done in 3.26s.

@codecov
Copy link

codecov bot commented Jan 19, 2018 •
edited
Loading

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   81.43%   81.43%           
=======================================
  Files          28       28           
  Lines         528      528           
  Branches       82       82           
=======================================
  Hits          430      430           
  Misses         66       66           
  Partials       32       32
Impacted Files Coverage Δ
src/extensions/functions/checkCLIForUpdates.ts 92.3% <100%> (ø) ⬆️
src/extensions/functions/reviewRule.ts 84.61% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32b5c0...b9668c6. Read the comment docs.

@GantMan GantMan merged commit dafa03f into master Jan 19, 2018
@GantMan GantMan deleted the touchups branch January 19, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GantMan @TravisBuddy