Feat: add German translations for all agent templates and optimized line breaks for template titles #10643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reaks for template titles
dosubot
bot
added
the
size:XL
KevinHuSh
reviewed
Oct 17, 2025
agent/templates/sql_assistant.json
Outdated
| "cross_languages": [], | ||
| "empty_response": "", | ||
| "kb_ids": [], | ||
| "kb_ids": [ |
There was a problem hiding this comment.
Appreciations! KB ID should not be here, should be?
There was a problem hiding this comment.
Yes, they are not necessary. I think this is some artifact from an older version. They work as a placeholder. Should I delete the IDs?
There was a problem hiding this comment.
Yes, the ID is a local one which can not be apply to other user.
KevinHuSh
changed the title
4 tasks
KevinHuSh
reviewed
Oct 22, 2025
agent/templates/sql_assistant.json
Outdated
| } | ||
| }, | ||
| "query": "{sys.query}", | ||
| "query": "sys.query", |
KevinHuSh
reviewed
Oct 22, 2025
There was a problem hiding this comment.
Please remove the unnecessary difference.
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR solve?
German translation for all agent template and optimizing line breaks in the title for the new translation.
Type of change