fix: improve shebang detection #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the following ways:
1. Handle whitespace in between the "!#" and the
executor/interpreter and between the executor/interpreter and
other args,
2. Handle the case where the first line of a script contains just
"#!", and
3. Handle multiple arguments (e.g., correctly detect that
`/usr/bin/env -S bash` is a shell shebang).
infertux
approved these changes
Jul 14, 2023
| @@ -38,8 +38,6 @@ def shellscript?(filename) | |||
| (shellscript_extension?(filename) && shellscript_syntax?(filename)) | |||
| end | |||
|
|
|||
| private | |||
There was a problem hiding this comment.
Nit: #shellscript_syntax? could have been left as private since we don't call/test it directly but that doesn't really matter.
There was a problem hiding this comment.
Whoops; happy to fix this.
| end | ||
|
|
||
| it "returns true for shell interpreters" do | ||
| aggregate_failures "valid shebang handling" do |
There was a problem hiding this comment.
TIL about aggregate_failures, nice :)
There was a problem hiding this comment.
I see an application for aggregate_failures in the runner spec as well; PR incoming :)
|
Just published Bashcov 3.0.3 with this fix, thank you! |
|
I'm geting bashcov-3.0.3/lib/bashcov/detective.rb:61:in `scan': invalid byte sequence in UTF-8 (ArgumentError)
return false if scanner.scan(/#!\s*/).nil?because it is trying to read a |
|
@gszep -- oh dear :(. Nevermind; running the Bashcov test suite triggers this, too. 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the following ways:
/usr/bin/env -S bashis a shell shebang).Inspired by #73 , expanded to account for other shebang shenanigans. Also, tests.