Additional tests for IPv6 addresses #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long time ago (2013) my company added IPv6 to our networking product. We produced a whole suite of test cases to check our IPv6 validation code. You can review the original at: https://github.com/richb-intermapper/IPv6-Regex/blob/master/test-ipv6-regex.pl
This PR translates the original perl code to Javascript. It finds many chases where the current isV6Format() function appears to accept illegal format addresses.
Use
npm run testmanycommand (ornode test/many.test.ts) to run the test that outputs failing V6 addresses.