Skip to content

Conversation

@zachs18
Copy link
Contributor

@zachs18 zachs18 commented Dec 26, 2023

The html_root_url currently links to an old version of the docs, so if you run cargo doc --no-deps on a downstream package that depends on [email protected], intra-doc links to indexmap types will resolve to [email protected] on docs.rs.

@cuviper
Copy link
Member

cuviper commented Dec 29, 2023

Oops! We should just remove this altogether, as it's no longer recommended: rust-lang/api-guidelines#230

@zachs18 zachs18 changed the title Update doc html_root_url Remove doc html_root_url Dec 29, 2023
@zachs18
Copy link
Contributor Author

zachs18 commented Dec 29, 2023

Okay, I've updated the PR to remove the attribute instead of updating it.

@cuviper
Copy link
Member

cuviper commented Dec 30, 2023

Thanks!

@cuviper cuviper merged commit 7e0862c into indexmap-rs:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants