This repository was archived by the owner on Jul 19, 2025. It is now read-only.
When importing images in mdx file create namespace #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illogic-al
force-pushed
the
illogic-al-mdx-image-import-namespacing
branch
3 times, most recently
from
a2fbcc6 to
7ba5a33
Compare
…th same name across different files.
This commit allows importing files with the same import name across different files. Tries to be valid for `import pic from file.jpeg` or `import * as pic from file.jpeg` imports.
illogic-al
force-pushed
the
illogic-al-mdx-image-import-namespacing
branch
from
e6103e6 to
1ac268a
Compare
…s between identically named images. Model actual situation being fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to be valid for
import pic from file.jpegorimport * as pic from file.jpegimports.Description
Given two files—file A located at
src/subdir2/file.mdxand file B located atsrc/subdir2/file.mdx— any imports with the same import name in both files will be 'compressed' to just one import: the last one.The changes introduced here make image imports across mdx files scoped to those specific files.
Documentation
Related Issues
Fixes closed issue gatsbyjs#17119. Gives more runway for (in progress?) refactor of gatsbyjs#25069 which is listed as target for providing a solution for 17119.