Skip to content

Conversation

@trustsafe
Copy link

When starting toot tui with HTTPS_PROXY set to a socks5h uri, an exception is thrown.

execute:
HTTPS_PROXY="socks5h://localhost:9050" toot tui

result:

  File "/home/account/.local/venv/test/lib/python3.11/site-packages/requests/adapters.py", line 483, in get_connection_with_tls_context
    proxy_manager = self.proxy_manager_for(proxy)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/account/.local/venv/test/lib/python3.11/site-packages/requests/adapters.py", line 282, in proxy_manager_for
    manager = self.proxy_manager[proxy] = SOCKSProxyManager(
                                          ^^^^^^^^^^^^^^^^^^
  File "/home/account/.local/venv/test/lib/python3.11/site-packages/requests/adapters.py", line 64, in SOCKSProxyManager
    raise InvalidSchema("Missing dependencies for SOCKS support.")
requests.exceptions.InvalidSchema: Missing dependencies for SOCKS support.

requests needs the pysocks library to function in this case. This PR adds the dependency. This shouldn't be a big issue downstream, as pysocks is already commonly packaged in Linux distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant