-
-
Notifications
You must be signed in to change notification settings - Fork 206
Open
Labels
argument consistencyissues related to argument naming/defaultsissues related to argument naming/defaultsfeaturea feature request or enhancementa feature request or enhancementlifecycleDeprecating old APIsDeprecating old APIs
Milestone
Description
In as_adjacency_matrix(), the attr parameter should be replaced by weights, to bring this in function in line with others that deal with weighted graphs.
attrtakes an edge attribute name uses the elements from it as weights.weightstakes a weight vector.
This change was already made in the C core for 0.10, so the R interface should mirror it if we want to keep things simple. Usign weights is also more flexible as it makes it possible for weights to come from elsewhere than an attribute, which is important for implementing certain kinds of functionality (see e.g. #905).
The change can be made gradually, with supporting both attr and weights for a while.
Metadata
Metadata
Assignees
Labels
argument consistencyissues related to argument naming/defaultsissues related to argument naming/defaultsfeaturea feature request or enhancementa feature request or enhancementlifecycleDeprecating old APIsDeprecating old APIs