Skip to content

chore(devcontainer): remove Dockerfile #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

chore(devcontainer): remove Dockerfile #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .devcontainer/devcontainer.json → .devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
{
"name": "ignition-api-8.1",
"build": {
"context": "..",
"dockerfile": "Dockerfile"
},
"image": "quay.io/ignition-devs/devcontainer-base:python",
"customizations": {
"vscode": {
"extensions": [
Expand All @@ -15,5 +12,6 @@
}
}
},
"onCreateCommand": "pre-commit install --hook-type pre-commit --hook-type commit-msg --hook-type pre-push"
"onCreateCommand": "pre-commit install --hook-type pre-commit --hook-type commit-msg --hook-type pre-push",
"postCreateCommand": "python2 -m pip install --requirement ignition-api/requirements.txt"
}
12 changes: 0 additions & 12 deletions .devcontainer/Dockerfile
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ repos:
- id: pydoclint-flake8
files: ^ignition-api/src/
args: [--config=ignition-api/.pydoclint]
- repo: https://github.com/coatl-dev/hadolint-coatl
rev: 2.12.1b0
hooks:
- id: hadolint
- repo: https://github.com/commitizen-tools/commitizen
rev: v4.8.3
hooks:
Expand Down