Fix InstaID precision without using bigint #256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugly I know, but with this patch you return the real InstaID, if needed to be checked or used for something else. The one returned now is not precise. |
|
Is this still relevant, or why did you delete the pr? |
|
The issue is still there, but this patch has a sum that in rare cases can output wrong value, I made a new pr #259 but I now came to the conclusion that the same problem is still there, but more rare. I'm a newbie in programming but with simple arithmetic I think I can solve this. I will try to edit my last pr #259 to fix it. EDIT: I don't know how to edit pr, so I made a new pr #260 that fix all problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.