Resolve missing config file #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Following #25 and PR #27, this PR is created and is based on #27.
In #27, the config file was added as a parameter, which is no longer optional. However, the intended idea was to make this parameter optional so that users configuring with the ifmVision Assistant or pure API are not required to reconfigure. They can simply publish the point clouds and ODS data without additional steps.
Additional Changes (form #27):
declare_parameterfor theconfig_fileparameter inods_node.cppcamera_node.cppandods_node.cppbecause this produces a lot of output.