Skip to content

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 21, 2022

  • feat(duckdb): overwrite views when calling register
  • chore: return options.default_backend from _default_backend
  • feat(api): return the table from ibis.connect('foo.csv')

@cpcloud cpcloud force-pushed the duckdb-more-convenience branch from 04a2f49 to c4dcca3 Compare September 21, 2022 15:32
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2022

Test Results

       6 files         6 suites   3m 54s ⏱️
3 142 tests 3 128 ✔️ 14 💤 0
9 420 runs  9 378 ✔️ 42 💤 0

Results for commit 22c2f74.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #4553 (c4dcca3) into master (6a6a453) will decrease coverage by 0.74%.
The diff coverage is 33.33%.

❗ Current head c4dcca3 differs from pull request most recent head 50036bd. Consider uploading reports for the commit 50036bd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4553      +/-   ##
==========================================
- Coverage   92.54%   91.79%   -0.75%     
==========================================
  Files         183      183              
  Lines       20004    20005       +1     
  Branches     2961     2962       +1     
==========================================
- Hits        18513    18364     -149     
- Misses       1114     1253     +139     
- Partials      377      388      +11     
Impacted Files Coverage Δ
ibis/backends/duckdb/__init__.py 54.28% <ø> (-40.96%) ⬇️
ibis/config.py 91.66% <0.00%> (-8.34%) ⬇️
ibis/backends/base/__init__.py 87.37% <50.00%> (-1.58%) ⬇️
ibis/backends/duckdb/registry.py 32.29% <0.00%> (-60.42%) ⬇️
ibis/backends/duckdb/datatypes.py 64.28% <0.00%> (-35.72%) ⬇️
ibis/backends/duckdb/compiler.py 92.30% <0.00%> (-5.13%) ⬇️
ibis/common/pretty.py 95.31% <0.00%> (-4.69%) ⬇️
ibis/backends/base/sql/alchemy/datatypes.py 88.78% <0.00%> (-2.34%) ⬇️
... and 7 more

@gforsyth
Copy link
Member

My connect tests for parquet and CSV are checking list_tables() for registration success -- I like returning the Table better -- probably an isinstance check is enough for those tests now.

@cpcloud cpcloud force-pushed the duckdb-more-convenience branch from c4dcca3 to 50036bd Compare September 21, 2022 17:27
@cpcloud cpcloud force-pushed the duckdb-more-convenience branch from 50036bd to 22c2f74 Compare September 21, 2022 17:30
@cpcloud cpcloud changed the title duckdb more convenience feat(duckdb): make it more convenient to access csv files Sep 21, 2022
@cpcloud cpcloud changed the title feat(duckdb): make it more convenient to access csv files feat(duckdb): make it more convenient to access files Sep 21, 2022
@cpcloud cpcloud added this to the 4.0.0 milestone Sep 21, 2022
@cpcloud cpcloud added ux User experience related issues duckdb The DuckDB backend labels Sep 21, 2022
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@cpcloud cpcloud merged commit ae07438 into ibis-project:master Sep 22, 2022
@cpcloud cpcloud deleted the duckdb-more-convenience branch September 22, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duckdb The DuckDB backend ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants