style: reformat to the Black default line length of 88 #4517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
force-pushed
the
black-default
branch
from
32519ce to
37a9719
Compare
Codecov Report
@@ Coverage Diff @@
## master #4517 +/- ##
==========================================
- Coverage 92.38% 91.99% -0.39%
==========================================
Files 189 189
Lines 20661 20661
Branches 2855 2855
==========================================
- Hits 19087 19007 -80
- Misses 1181 1261 +80
Partials 393 393
|
|
Strangely github doesn't crosslink discussions here. See the relevant thread at #4515 |
|
Based on the discussion in #4515, it looks like a line length of 88 is preferred, matching what's done here. Is there anything left to do here? |
|
We need to rerun the formatter on the current main branch, also we should add the created formatting commit to |
|
@kszucs Are you opposed to this change? |
Nope, I don't have a strong opinion on this. |
cpcloud
added
refactor
|
@kszucs Shall we merge? I'll add the commit to the ignore revs file once it lands upstream. |
kszucs
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the line length of the codebase to the black default of 88