-
Notifications
You must be signed in to change notification settings - Fork 4
IBX-9845: Upgraded Solr to version 9.8.1 #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/lib/Query/Common/CriterionVisitor/MapLocation/MapLocationDistanceRange.php
Outdated
Show resolved
Hide resolved
|
{ | ||
if (is_array($criterion->value)) { | ||
$minDistance = $criterion->value[0]; | ||
$maxDistance = $criterion->value[1] ?? 63510; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 63510 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, it comes from the direct conversion of https://github.com/ibexa/solr/pull/95/files#diff-1127a1f6be52315ed65f6d9331bab2c616849de0124f37a619b61043c88f347aR70 . I suppose the literal 63510 there is just a “magic number” fallback for the upper bound of the distance filter. It guarantees that, if the user didn’t supply a maximum distance, we’ll end up filtering out nothing on the high end.
Maybe it could be replaced by 20038, if needed. For example, as a MAX_EARTH_DISTANCE_KM or something.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on Ibexa DXP 5.0 exp.
Related PRs:
Description:
This PR introduces support for Solr 9.8.1, in addition to maintaining compatibility with Solr 7.7.x and 8.11.x.
The update affects initialization scripts, configuration file selection, and CI workflows, ensuring smooth integration and automated testing for the latest Solr LTS.
.github/init_solr.sh
was updated to support Solr 9.8.1, including logic to choose different config files based on the Solr version (Solr 9.x uses managed-schema and new custom-fields-types).LatLonType
toLatLonPointSpatialField
in Solr 9.If Solr version 9 is used I,t is obligatory to set:
For QA:
Documentation: