-
Notifications
You must be signed in to change notification settings - Fork 230
Removed schema references from multiple/single queries #8699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
AureMonke
commented
Oct 29, 2025
- Removed repetitive withSchemaReferences from queries
- Fix for labels of some classes are different when loading the same schema using JSON and Incremental locater
…hema using JSON and Incremental locater
| import { IncrementalSchemaReader } from "./IncrementalSchemaReader"; | ||
|
|
||
| interface IncrementalSchemaInfo extends SchemaInfo { | ||
| export interface IncrementalSchemaInfo extends SchemaInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking, shouldn't that rather be internal? We don't want to use it outside of itwinjs.
|
Don't forget to do an extract-api, we changed a few interfaces. |
…ncremental-schema-loading/query-fix
|
This pull request is now in conflicts. Could you fix it @AureMonke? 🙏 |
…ncremental-schema-loading/query-fix
| } | ||
| } | ||
|
|
||
| private decodeNameToDisplayLabel(props: MutableClassProps | MutablePropertyProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be improved. The "ecNameRegex" is already defined in ECName, it's actually a "replaced character as hex"-regex.
You could just always call ECName.decode, and it would do nothing if the regex doesn't match. No need to duplicate the regex into this method, I think the logic remains the same without the regex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: Ah now I see why this. You only want to set the label if there are any encoded chars in the name.
In that case we should add a method for it to ECName, so we don't have to copy the regex. Something like ECName.hasEncodedCharacters() : bool