TreeNode hover styles only applied when hover is supported
#2618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
rroyb
and removed request for
a team
mayank99
approved these changes
Jul 30, 2025
r100-stack
commented
Jul 30, 2025
| color: var(--iui-color-text-hover); | ||
|
|
||
| .iui-tree-node-content-caption { | ||
| @media (any-hover: hover) { |
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
No idea. We have run into issues with hover queries in css-workshop before, but haven't figured out why it happens or if there is a workaround.
Maybe for this PR we can delete the hover visual test.
Contributor
Author
There was a problem hiding this comment.
Ohh, I see. Commented out that test with a TODO to investigate this later (c03f50c).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2564, at least indirectly.
This PR follows the suggestion of adding hover styles only when hover is supported by the input mechanism.
Testing
Confirmed in the iPad simulator that the hover styles no longer show up in the sandbox from #2564.
Temporarily commented out the Tree hover test since it doesn't trigger the hover correctly, or something along those lines (#2618 (comment)). Added a TODO to investigate this later.
Docs
Added css and react patch changesets.