Sort Git tag by date in goreleaser

[EnriqueL8]

Failure in v1.3.3 release https://github.com/hyperledger/firefly-cli/actions/runs/14037243248/job/39298579545 is caused by the GoReleaser tool thinking the release candidate v1.3.3-rc.1 is the newest one because of the way it sorts..

Found https://github.com/goreleaser/goreleaser/pull/3611/files#diff-387a86836bbc80da7865b5ccf079e7b6d7c82a673d5c6538892e24e1bdf17d14R9-R14

[peterbroadhurst]

ok - reading to understand why it's picking pre-release

[peterbroadhurst]

So we run goreleaser for both prerelease and not, and it sets the appropriate tag in the go system it seems https://goreleaser.com/customization/release/#github

[peterbroadhurst]

ok - so here's the description of the option that's been picked, and it says this is about more than one tag in the same commit 👀

  # What should be used to sort tags when gathering the current and previous
  # tags if there are more than one tag in the same commit.
  #
  # Default: '-version:refname'.
  tag_sort: -version:creatordate

[peterbroadhurst]

So I think @EnriqueL8 - you're saying we:

1. Tagged a commit of the CLI as v1.3.3-rc.1
2. Chose to re-tag the very same commit as v1.3.3
   • We must never have done this before
3. Tried to run go-releaser again, and it failed

[peterbroadhurst]

So... actually you will need to "un tag" the current commit as v1.3.3 (because this fix is a new commit), then tag the commit after this builds as v1.3.3.

That will render this fix void for this release (because there won't be duplicate tags on a commit any more), but will mean future releases don't hit this.

[EnriqueL8]

Exactly! As there weren't any fixes needed between the RC and the final version we have retagged the same commit with a newer tag. The GoReleaser would take the oldest one and that flag sorts by creation time so it take the first one.

As you said, need to go delete the v1.3.3 tag, merge this fix and then release v1.3.3 again pointing at a new commit so we wouldn't hit this issue but fix it for the future :)

[peterbroadhurst]

I checked and it seems you've deleted the v1.3.3 release