update RPC methods : fill gasPrice for post london 1559 transaction #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <[email protected]>
Contributor
|
Reminder to revisit json-rpc effectiveGas/gasPrice fields in light of ethereum/execution-specs#251 |
matkt
force-pushed
the
feature/gas-price-1559-trx
branch
from
714d260 to
ae35755
Compare
Signed-off-by: Karim TAAM <[email protected]>
matkt
force-pushed
the
feature/gas-price-1559-trx
branch
from
6ef1587 to
9c1d29e
Compare
matkt
added
doc-change-required
garyschulte
requested changes
Aug 24, 2021
Contributor
garyschulte
left a comment
garyschulte
left a comment
There was a problem hiding this comment.
see comments about effectiveGas vs effectivePriorityFee
...va/org/hyperledger/besu/ethereum/api/jsonrpc/internal/results/TransactionCompleteResult.java
Outdated
Show resolved
Hide resolved
...reum/api/src/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/JsonRpcHttpServiceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karim TAAM <[email protected]>
garyschulte
requested changes
Aug 26, 2021
| assertThat(tcr.getGasPrice()).isNull(); | ||
| assertThat(tcr.getGasPrice()).isNotEmpty(); | ||
| assertThat(tcr.getGasPrice()) | ||
| .isEqualTo(Quantity.create(transaction.getEffectivePriorityFeePerGas(Optional.of(7L)))); |
Contributor
There was a problem hiding this comment.
I think this is why the unit test failure
Signed-off-by: Karim TAAM <[email protected]>
Contributor
bgravenorst
removed
doc-change-required
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…yperledger#2535) Signed-off-by: Karim TAAM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM [email protected]
PR description
After london for transactions returned on the rpc, we need to fill the gasPrice field as follows:
gasPrice (for Legacy transaction)
maxFeeCapPerGas (for 1559 transaction)
effectiveGas (for 1559 transaction)
gasPrice (for Legacy transaction)
Fixed Issue(s)
Changelog