misc: add pytests.nix dev utility
#5501
Conversation
Signed-off-by: quacumque <[email protected]>
0x009922
added
the
Chore
0x009922
requested review from
mversic,
outoftardis,
DCNick3 and
dima74
as code owners
| BIN_IROHAD = "target/release/irohad"; | ||
| BIN_IROHA = "target/release/iroha"; | ||
| BIN_KAGAMI = "target/release/kagami"; |
There was a problem hiding this comment.
What’s the rationale for switching to release builds? Is it to align with integration tests that use cargo install? However, unless we’re testing non‑functional requirements, wouldn’t debug builds suffice?
There was a problem hiding this comment.
Yes, debug builds would totally suffice.
I made it to align with the integration tests. Which aren't, btw, using cargo install anymore; they rely on target/release bins too.
There was a problem hiding this comment.
It might be helpful to update the README.md or CONTRIBUTING.md with instructions on how to run the integration tests.
| # This is not a final product, so feel free to edit manually to adjust tests running or do whatever is convenient | ||
| # for you right now. | ||
| # | ||
| # Build binaries: `cargo build --release --bins` |
There was a problem hiding this comment.
Should the guide in thepytest/* folder be updated?
There was a problem hiding this comment.
Mentioned, intentionally with minimal effort
Signed-off-by: quacumque <[email protected]>
| BIN_IROHAD = "target/release/irohad"; | ||
| BIN_IROHA = "target/release/iroha"; | ||
| BIN_KAGAMI = "target/release/kagami"; |
There was a problem hiding this comment.
It might be helpful to update the README.md or CONTRIBUTING.md with instructions on how to run the integration tests.
Instead of setting up Python, Poetry,
requirements.txt, setting up ENV vars, moving between directories and typing commands manually, just do:This script is intentionally simple, and serves both as a documentation and a tool to quickly modify it locally and run tests as you like (without necessarily committing changes back to the script).